Skip to content

DRIVERS-3262: appendMetadata() does not append duplicate metdata #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Sep 12, 2025
Merged

DRIVERS-3262: appendMetadata() does not append duplicate metdata #1833

merged 15 commits into from
Sep 12, 2025

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Sep 3, 2025 •
edited
Loading

This PR updates the handshake specification to clarify that drivers MUST NOT append the same metadata multiple times to a MongoClient.

Please complete the following before merging:

  • Update changelog.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, and sharded
    clusters).

@baileympearson baileympearson changed the title DRIVERS-3262: appendClientMetadata() does not append duplicate metdata DRIVERS-3262: appendMetadata() does not append duplicate metdata Sep 3, 2025
@baileympearson baileympearson mentioned this pull request Sep 4, 2025
Merged
5 tasks
@baileympearson baileympearson marked this pull request as ready for review September 4, 2025 20:17
@baileympearson baileympearson requested a review from a team as a code owner September 4, 2025 20:17
@baileympearson baileympearson requested review from JamesKovacs and dariakp and removed request for a team September 4, 2025 20:17
dariakp
dariakp requested changes Sep 5, 2025
View reviewed changes
dariakp
dariakp requested changes Sep 9, 2025
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a couple of small things here; will approve once cross-referenced with Node implementation

dariakp
dariakp requested changes Sep 9, 2025
View reviewed changes
@dariakp dariakp self-assigned this Sep 9, 2025
JamesKovacs
JamesKovacs approved these changes Sep 9, 2025
View reviewed changes
Copy link
Contributor

@JamesKovacs JamesKovacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

addaleax
addaleax reviewed Sep 9, 2025
View reviewed changes
prestonvasquez
prestonvasquez requested changes Sep 10, 2025
View reviewed changes
@prestonvasquez prestonvasquez mentioned this pull request Sep 10, 2025
Closed
3 tasks
prestonvasquez
prestonvasquez requested changes Sep 10, 2025
View reviewed changes
dariakp
dariakp reviewed Sep 10, 2025
View reviewed changes
dariakp
dariakp requested changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending typo fix, negotiated wording in the spec text, and the removal of the redundant test case from the duplicate metadata set in Test 3

dariakp
dariakp requested changes Sep 10, 2025
View reviewed changes
prestonvasquez
prestonvasquez approved these changes Sep 12, 2025
View reviewed changes
Copy link
Member

@prestonvasquez prestonvasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Go Driver implementation here: mongodb/mongo-go-driver#2197

@dariakp dariakp merged commit e133c20 into mongodb:master Sep 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvasquez prestonvasquez prestonvasquez approved these changes

@dariakp dariakp dariakp approved these changes

@addaleax addaleax Awaiting requested review from addaleax

@JamesKovacs JamesKovacs Awaiting requested review from JamesKovacs

Assignees

@dariakp dariakp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@baileympearson @JamesKovacs @addaleax @prestonvasquez @dariakp